Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electron): 🩹 fix connection issue of domain name keys #1763

Merged
merged 1 commit into from
Oct 30, 2023
Merged

fix(electron): 🩹 fix connection issue of domain name keys #1763

merged 1 commit into from
Oct 30, 2023

Conversation

jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Oct 30, 2023 •
edited
Loading

This PR reverts part of the changes in #1663 , which is critical to domain name keys.

This helps address the issue #1760

@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@daniellacosse daniellacosse added the needs test Pull requests that require tests label Oct 30, 2023
@jyyi1 jyyi1 marked this pull request as ready for review October 30, 2023 19:28
@jyyi1 jyyi1 requested a review from a team as a code owner October 30, 2023 19:28
@jyyi1 jyyi1 removed the needs test Pull requests that require tests label Oct 30, 2023
@jyyi1 jyyi1 changed the title fix(electron): fix connection issue of domain name keys fix(electron): 🩹 fix connection issue of domain name keys Oct 30, 2023
@fortuna fortuna mentioned this pull request Oct 30, 2023
Closed
@jyyi1 jyyi1 merged commit c68836d into master Oct 30, 2023
33 checks passed
@jyyi1 jyyi1 deleted the junyi/fix-hostname-key-connect branch October 30, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna approved these changes

@daniellacosse daniellacosse daniellacosse approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jyyi1 @fortuna @daniellacosse